linux-kernel - Re: [PATCH 1/7] dtbindings: display: bcm2711-hdmi: Correct bindings for 2712

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0167e83b-7b73-4784-b022-903272866fe1@kernel.org>
Date: Mon, 2 Dec 2024 16:16:58 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Eric Anholt <eric@...olt.net>,
 Maíra Canal <mcanal@...lia.com>,
 Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
 Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
 Doug Berger <opendmb@...il.com>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
 linux-gpio@...r.kernel.org
Subject: Re: [PATCH 1/7] dtbindings: display: bcm2711-hdmi: Correct bindings
 for 2712

On 02/12/2024 15:31, Dave Stevenson wrote:
> The previous patch just adding the compatible missed out that the


"The previous" is meaningless in this context. There is nothing
previous. Refer to commit (see submitting patches).

> number of interrupts changed
> 
> Fixes: 62948c62abca ("dt-bindings: display: Add BCM2712 HDMI bindings")

There is no such commit in linux-next. Fix patches while they are on the
mailing list. If you refer here to broken DRM process, then basically
you are on your own because we won't able to see it.

> Signed-off-by: Dave Stevenson <dave.stevenson@...pberrypi.com>

Typo in subject prefix. It's dt-bindings.

> ---
>  .../bindings/display/brcm,bcm2711-hdmi.yaml        | 44 +++++++++++++++-------
>  1 file changed, 30 insertions(+), 14 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> index 6d11f5955b51..6af342c9b6b8 100644
> --- a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> @@ -56,22 +56,38 @@ properties:
>        - const: cec
>  
>    interrupts:
> -    items:
> -      - description: CEC TX interrupt
> -      - description: CEC RX interrupt
> -      - description: CEC stuck at low interrupt
> -      - description: Wake-up interrupt
> -      - description: Hotplug connected interrupt
> -      - description: Hotplug removed interrupt
> +    oneOf:
> +      - items:
> +        - description: CEC TX interrupt
> +        - description: CEC RX interrupt
> +        - description: CEC stuck at low interrupt
> +        - description: Wake-up interrupt
> +        - description: Hotplug connected interrupt
> +        - description: Hotplug removed interrupt

You need to narrow these per variant in allOf:if:then.
Best regards,
Krzysztof