linux-kernel - Re: [PATCH v4 2/3] iio: chemical: bme680: add regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z0376uLnf8xoqSU7@vamoirid-laptop>
Date: Mon, 2 Dec 2024 19:26:50 +0100
From: Vasileios Amoiridis <vassilisamir@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, andriy.shevchenko@...ux.intel.com,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] iio: chemical: bme680: add regulators

On Sat, Nov 30, 2024 at 02:26:48PM +0000, Jonathan Cameron wrote:
> On Thu, 28 Nov 2024 20:32:45 +0100
> Vasileios Amoiridis <vassilisamir@...il.com> wrote:
> 
> > Add support for the regulators described in the dt-binding.
> > 
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
> > ---
> >  drivers/iio/chemical/bme680_core.c | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c
> > index 9783953e64e0..186e0a6cc2d7 100644
> > --- a/drivers/iio/chemical/bme680_core.c
> > +++ b/drivers/iio/chemical/bme680_core.c
> > @@ -15,6 +15,7 @@
> >  #include <linux/log2.h>
> >  #include <linux/module.h>
> >  #include <linux/regmap.h>
> > +#include <linux/regulator/consumer.h>
> >  
> >  #include <linux/iio/buffer.h>
> >  #include <linux/iio/iio.h>
> > @@ -111,6 +112,10 @@ enum bme680_scan {
> >  	BME680_GAS,
> >  };
> >  
> > +static const char *const bme680_supply_names[] = { "vdd", "vddio" };
> > +
> > +#define BME680_NUM_SUPPLIES ARRAY_SIZE(bme680_supply_names)
> Trivial: What benefit do we get from this define that is used in one place?
> 

Hi Jonathan,

Thanks for the review! This here made more sense in the beginning
because I was using it in more places but now it is indeed only used in
one place. I might as well drop it.

Cheers,
Vasilis

> > +
> >  struct bme680_data {
> >  	struct regmap *regmap;
> >  	struct bme680_calib bme680;
> > @@ -1114,6 +1119,14 @@ int bme680_core_probe(struct device *dev, struct regmap *regmap,
> >  	data->heater_dur = 150;  /* milliseconds */
> >  	data->preheat_curr_mA = 0;
> >  
> > +	ret = devm_regulator_bulk_get_enable(dev, BME680_NUM_SUPPLIES,
> 	ret = devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(bme680_supply_names),
> 					     bme680_supply_names);
> 
> And don't worry about slightly over 80 chars line.
> 
> > +					     bme680_supply_names);
> > +	if (ret)
> > +		return dev_err_probe(dev, ret,
> > +				     "failed to get and enable supplies.\n");
> > +
> > +	fsleep(BME680_STARTUP_TIME_US);
> > +
> >  	ret = regmap_write(regmap, BME680_REG_SOFT_RESET, BME680_CMD_SOFTRESET);
> >  	if (ret < 0)
> >  		return dev_err_probe(dev, ret, "Failed to reset chip\n");
>