linux-kernel - Re: [PATCH] iio: adc: ti-ads1119: fix sample size in scan struct for triggered buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241202194622.GA70146@francesco-nb>
Date: Mon, 2 Dec 2024 20:46:22 +0100
From: Francesco Dolcini <francesco@...cini.it>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Francesco Dolcini <francesco@...cini.it>,
	João Paulo Gonçalves <jpaulo.silvagoncalves@...il.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	João Paulo Gonçalves <joao.goncalves@...adex.com>,
	Francesco Dolcini <francesco.dolcini@...adex.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ti-ads1119: fix sample size in scan struct for
 triggered buffer

On Mon, Dec 02, 2024 at 08:18:44PM +0100, Javier Carrasco wrote:
> This device returns signed, 16-bit samples as stated in its datasheet
> (see 8.5.2 Data Format). That is in line with the scan_type definition
> for the IIO_VOLTAGE channel, but 'unsigned int' is being used to read
> and push the data to userspace.
> 
> Given that the size of that type depends on the architecture (at least
> 2 bytes to store values up to 65535, but its actual size is often 4
> bytes), use the 's16' type to provide the same structure in all cases.
> 
> Fixes: a9306887eba4 ("iio: adc: ti-ads1119: Add driver")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

Reviewed-by: Francesco Dolcini <francesco.dolcini@...adex.com>
Cc: stable@...r.kernel.org

Thanks,
Francesco