linux-kernel - [PATCH] checkpatch: allow multiple Reported-by tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241202-multi-close-v1-1-a68240379db1@chromium.org>
Date: Mon, 02 Dec 2024 20:42:24 +0000
From: Ricardo Ribalda <ribalda@...omium.org>
To: Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>, 
 Dwaipayan Ray <dwaipayanray1@...il.com>, 
 Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc: linux-kernel@...r.kernel.org, Hans Verkuil <hverkuil@...all.nl>, 
 Ricardo Ribalda <ribalda@...omium.org>
Subject: [PATCH] checkpatch: allow multiple Reported-by tags

If a patch has been reported by multiple individuals, allow a single
Closes tag.

Given this patch:

: Reported-by: kernel test robot <lkp@...el.com>
: Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/
: Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
: Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/

Allow also this:

: Reported-by: kernel test robot <lkp@...el.com>
: Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
: Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/

Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9eed3683ad76..d6a79993fdf1 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3189,7 +3189,7 @@ sub process {
 				if (!defined $lines[$linenr]) {
 					WARN("BAD_REPORTED_BY_LINK",
 					     "Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . "\n");
-				} elsif ($rawlines[$linenr] !~ /^closes:\s*/i) {
+				} elsif ($rawlines[$linenr] !~ /^closes:\s*/i && $rawlines[$linenr] !~ /^reported(?:|-and-tested)-by:\s*/i) {
 					WARN("BAD_REPORTED_BY_LINK",
 					     "Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . $rawlines[$linenr] . "\n");
 				}

---
base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
change-id: 20241202-multi-close-3e23042d5185

Best regards,
-- 
Ricardo Ribalda <ribalda@...omium.org>