linux-kernel - Re: [PATCH 3/4] mm/swap_cgroup: simplify swap cgroup definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z0418j_FHJ2V4fJC@google.com>
Date: Mon, 2 Dec 2024 22:34:26 +0000
From: Roman Gushchin <roman.gushchin@...ux.dev>
To: Kairui Song <kasong@...cent.com>
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
	Chris Li <chrisl@...nel.org>, Hugh Dickins <hughd@...gle.com>,
	"Huang, Ying" <ying.huang@...el.com>,
	Yosry Ahmed <yosryahmed@...gle.com>,
	Shakeel Butt <shakeel.butt@...ux.dev>,
	Johannes Weiner <hannes@...xchg.org>,
	Barry Song <baohua@...nel.org>, Michal Hocko <mhocko@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] mm/swap_cgroup: simplify swap cgroup definitions

On Tue, Dec 03, 2024 at 02:41:53AM +0800, Kairui Song wrote:
> From: Kairui Song <kasong@...cent.com>
> 
> Remove the intermediate struct swap_cgroup, it just a unsigned short
> wrapper, simplify the code.
> 
> Also zero the map on initialization to prevent unexpected behaviour as
> swap cgroup helpers are suppose to return 0 on error.
> 
> Signed-off-by: Kairui Song <kasong@...cent.com>

Please, merge this one into the next one, so it's easier to follow
how the end result looks like.

It seems like v2 is coming for the next patch in any case.

Thanks!