linux-kernel - Re: [PATCH] Revert "net/ncsi: change from ndo_set_mac_address to dev_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241202154922.0644c7a9@kernel.org>
Date: Mon, 2 Dec 2024 15:49:22 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Potin Lai <potin.lai.pt@...il.com>
Cc: Samuel Mendoza-Jonas <sam@...dozajonas.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Patrick Williams
 <patrick@...cx.xyz>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Cosmo Chou <cosmo.chou@...ntatw.com>, Potin Lai <potin.lai@...ntatw.com>
Subject: Re: [PATCH] Revert "net/ncsi: change from ndo_set_mac_address to
 dev_set_mac_address"

On Fri, 29 Nov 2024 17:12:56 +0800 Potin Lai wrote:
> This reverts commit 790071347a0a1a89e618eedcd51c687ea783aeb3.
> 
> We are seeing kernel panic when enabling two NCSI interfaces at same
> time. It looks like mutex lock is being used in softirq caused the
> issue.

I agree with Andrew that revert makes sense. On top of his suggestions
please add a correctly formatted Fixes tag and make sure you CC the
authors of the buggy change, and post a v2.
-- 
pw-bot: cr