[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <qmbaftzr4ww35txfjvt6iao5g5jjikx5swgh6cdqbiu36dwo2y@74vnlk2a3ihn>
Date: Mon, 2 Dec 2024 08:40:22 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ben Zong-You Xie <ben717@...estech.com>
Cc: linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, ukleinek@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: add atcpit100-pwm
On Mon, Dec 02, 2024 at 02:01:46PM +0800, Ben Zong-You Xie wrote:
> Document devicetree bindings for Andes atcpit100-pwm.
>
> Signed-off-by: Ben Zong-You Xie <ben717@...estech.com>
> ---
> .../bindings/pwm/andestech,atcpit100-pwm.yaml | 51 +++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/andestech,atcpit100-pwm.yaml
>
> diff --git a/Documentation/devicetree/bindings/pwm/andestech,atcpit100-pwm.yaml b/Documentation/devicetree/bindings/pwm/andestech,atcpit100-pwm.yaml
> new file mode 100644
> index 000000000000..4b707f32ad72
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/andestech,atcpit100-pwm.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/andestech,atcpit100-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Andes atcpit100 PWM
> +
> +maintainers:
> + - Ben Zong-You Xie <ben717@...estech.com>
> +
> +allOf:
> + - $ref: pwm.yaml#
> +
> +properties:
> + compatible:
> + const: andestech,atcpit100-pwm
Previously, before we removed it in 2022, this was just
andestech,atcpit100, so questions:
1. Why are you re-introducing it? Please address all the comments or
aspects leading to removal.
2. Why are you using different compatible? Is this one device?
Best regards,
Krzysztof
Powered by blists - more mailing lists