lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <db8187d8-5ec6-4aaa-bd61-21cd3a806c66@tuxon.dev>
Date: Mon, 2 Dec 2024 10:08:25 +0200
From: Claudiu Beznea <claudiu.beznea@...on.dev>
To: Mihai Sain <mihai.sain@...rochip.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, nicolas.ferre@...rochip.com,
 alexandre.belloni@...tlin.com, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: microchip: sam9x7: Move i2c address/size to
 dtsi

Hi, Mihai,

On 22.11.2024 10:05, Mihai Sain wrote:
> Since these properties are common for all i2c subnodes,
> move them to SoC dtsi from board dts.
> 
> Signed-off-by: Mihai Sain <mihai.sain@...rochip.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...on.dev>

> ---
>  .../dts/microchip/at91-sam9x75_curiosity.dts  |  2 --
>  arch/arm/boot/dts/microchip/sam9x7.dtsi       | 26 +++++++++++++++++++
>  2 files changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
> index 87b6ea97590b..d453800f8e35 100644
> --- a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
> @@ -88,8 +88,6 @@ &flx6 {
>  };
>  
>  &i2c6 {
> -	#address-cells = <1>;
> -	#size-cells = <0>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_flx6_default>;
>  	i2c-analog-filter;
> diff --git a/arch/arm/boot/dts/microchip/sam9x7.dtsi b/arch/arm/boot/dts/microchip/sam9x7.dtsi
> index beb1f34b38d3..aedba0a8318f 100644
> --- a/arch/arm/boot/dts/microchip/sam9x7.dtsi
> +++ b/arch/arm/boot/dts/microchip/sam9x7.dtsi
> @@ -151,6 +151,8 @@ i2c4: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <13 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 13>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -220,6 +222,8 @@ i2c5: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <14 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 14>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -312,6 +316,8 @@ i2c11: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <32 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 32>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -362,6 +368,8 @@ i2c12: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <33 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 33>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -533,6 +541,8 @@ i2c6: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <9 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 9>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -583,6 +593,8 @@ i2c7: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <10 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 10>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -633,6 +645,8 @@ i2c8: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <11 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 11>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -702,6 +716,8 @@ i2c0: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <5 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 5>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -771,6 +787,8 @@ i2c1: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <6 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 6>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -840,6 +858,8 @@ i2c2: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <7 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 7>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -909,6 +929,8 @@ i2c3: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <8 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 8>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -984,6 +1006,8 @@ i2c9: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <15 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 15>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -1034,6 +1058,8 @@ i2c10: i2c@600 {
>  				compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
>  				reg = <0x600 0x200>;
>  				interrupts = <16 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 16>;
>  				dmas = <&dma0
>  					(AT91_XDMAC_DT_MEM_IF(0) |

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ