linux-kernel - Re: [PATCH] mailbox: th1520: Fix a NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90d4515c-835f-4aaa-8c9f-263f23bdfdb2@samsung.com>
Date: Mon, 2 Dec 2024 10:31:18 +0100
From: Michal Wilczynski <m.wilczynski@...sung.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Drew Fustini <drew@...7.com>, Guo Ren <guoren@...nel.org>, Fu Wei
	<wefu@...hat.com>, Jassi Brar <jassisinghbrar@...il.com>,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mailbox: th1520: Fix a NULL vs IS_ERR() bug



On 11/30/24 11:07, Dan Carpenter wrote:
> The devm_ioremap() function doesn't return error pointers, it returns
> NULL.  Update the error checking to match.
> 
> Fixes: 5d4d263e1c6b ("mailbox: Introduce support for T-head TH1520 Mailbox driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/mailbox/mailbox-th1520.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/mailbox-th1520.c b/drivers/mailbox/mailbox-th1520.c
> index 4e84640ac3b8..e16e7c85ee3c 100644
> --- a/drivers/mailbox/mailbox-th1520.c
> +++ b/drivers/mailbox/mailbox-th1520.c
> @@ -387,8 +387,10 @@ static void __iomem *th1520_map_mmio(struct platform_device *pdev,
>  
>  	mapped = devm_ioremap(&pdev->dev, res->start + offset,
>  			      resource_size(res) - offset);
> -	if (IS_ERR(mapped))
> +	if (!mapped) {
>  		dev_err(&pdev->dev, "Failed to map resource: %s\n", res_name);
> +		return ERR_PTR(-ENOMEM);
> +	}
>  
>  	return mapped;
>  }


Looks good, thanks !
Reviewed-by: Michal Wilczynski <m.wilczynski@...sung.com>