linux-kernel - Re: [PATCH] kbuild: Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241202100036.GL24400@noisy.programming.kicks-ass.net>
Date: Mon, 2 Dec 2024 11:00:36 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: zhangjiao2 <zhangjiao2@...s.chinamobile.com>
Cc: jpoimboe@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: Fix the wrong format specifier

On Mon, Dec 02, 2024 at 12:11:26PM +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@...s.chinamobile.com>
> 
> The format specifier of "unsigned long" in printf()
> should be "%lu", not "%ld".

Your subject is wrong, also, who cares? Why did you write this patch?

> Signed-off-by: zhang jiao <zhangjiao2@...s.chinamobile.com>
> ---
>  tools/objtool/check.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index 4ce176ad411f..9c36bb519cf3 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -4934,10 +4934,10 @@ int check(struct objtool_file *file)
>  		disas_warned_funcs(file);
>  
>  	if (opts.stats) {
> -		printf("nr_insns_visited: %ld\n", nr_insns_visited);
> -		printf("nr_cfi: %ld\n", nr_cfi);
> -		printf("nr_cfi_reused: %ld\n", nr_cfi_reused);
> -		printf("nr_cfi_cache: %ld\n", nr_cfi_cache);
> +		printf("nr_insns_visited: %lu\n", nr_insns_visited);
> +		printf("nr_cfi: %lu\n", nr_cfi);
> +		printf("nr_cfi_reused: %lu\n", nr_cfi_reused);
> +		printf("nr_cfi_cache: %lu\n", nr_cfi_cache);
>  	}
>  
>  out:
> -- 
> 2.33.0
> 
> 
>