linux-kernel - Re: [PATCH v4 09/19] drm/imx: Add i.MX8qxp Display Controller display engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73540c67-4d4e-4deb-b5c1-2caac50edf2d@nxp.com>
Date: Mon, 2 Dec 2024 10:16:05 +0800
From: Liu Ying <victor.liu@....com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
 p.zabel@...gutronix.de, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
 festevam@...il.com, glx@...utronix.de, vkoul@...nel.org, kishon@...nel.org,
 aisheng.dong@....com, agx@...xcpu.org, francesco@...cini.it,
 frank.li@....com, dmitry.baryshkov@...aro.org
Subject: Re: [PATCH v4 09/19] drm/imx: Add i.MX8qxp Display Controller display
 engine

On 12/01/2024, Uwe Kleine-König wrote:
> Hello,

Hello,

> 
> On Mon, Nov 25, 2024 at 05:33:06PM +0800, Liu Ying wrote:
>> +struct platform_driver dc_de_driver = {
>> +	.probe = dc_de_probe,
>> +	.remove_new = dc_de_remove,
> 
> Please use .remove here. Also in a few other patches of this series.

Will use .remove in next version.  Thanks.

> 
> Best regards
> Uwe
> 
>> +	.driver = {
>> +		.name = "imx8-dc-display-engine",
>> +		.suppress_bind_attrs = true,
>> +		.of_match_table = dc_de_dt_ids,
>> +		.pm = pm_sleep_ptr(&dc_de_pm_ops),
>> +	},
>> +};

-- 
Regards,
Liu Ying