linux-kernel - Re: [PATCH 1/2] cgroup: Make operations on the cgroup root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024120257-icky-audio-cf30@gregkh>
Date: Mon, 2 Dec 2024 11:17:00 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Siddh Raman Pant <siddh.raman.pant@...cle.com>
Cc: Sasha Levin <sashal@...nel.org>, stable <stable@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	cgroups@...r.kernel.org,
	Shivani Agarwal <shivani.agarwal@...adcom.com>
Subject: Re: [PATCH 1/2] cgroup: Make operations on the cgroup root_list RCU
 safe

On Mon, Dec 02, 2024 at 03:41:01PM +0530, Siddh Raman Pant wrote:
> From: Yafang Shao <laoar.shao@...il.com>
> 
> commit d23b5c577715892c87533b13923306acc6243f93 upstream.
> 
> At present, when we perform operations on the cgroup root_list, we must
> hold the cgroup_mutex, which is a relatively heavyweight lock. In reality,
> we can make operations on this list RCU-safe, eliminating the need to hold
> the cgroup_mutex during traversal. Modifications to the list only occur in
> the cgroup root setup and destroy paths, which should be infrequent in a
> production environment. In contrast, traversal may occur frequently.
> Therefore, making it RCU-safe would be beneficial.
> 
> Signed-off-by: Yafang Shao <laoar.shao@...il.com>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> [fp: adapt to 5.10 mainly because of changes made by e210a89f5b07
>  ("cgroup.c: add helper __cset_cgroup_from_root to cleanup duplicated
>  codes")]
> Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>
> [Shivani: Modified to apply on v5.4.y]
> Signed-off-by: Shivani Agarwal <shivani.agarwal@...adcom.com>
> Reviewed-by: Siddh Raman Pant <siddh.raman.pant@...cle.com>

I'm confused.  You do know what signed-off-by means, right?  When
sending a patch on, you MUST sign off on it.

Please work with other developers of the Oracle Linux kernel team to get
this right and send it as a whole new series, properly versioned, and
tested in in a format that we can take this in.

thanks,

greg k-h