linux-kernel - Re: [PATCH v9 3/9] dt-bindings: power: supply: max17042: remove reg from required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89f721a4-6af4-4cb0-aa02-9972dfcdc8fb@kernel.org>
Date: Mon, 2 Dec 2024 11:18:12 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dzmitry Sankouski <dsankouski@...il.com>,
 Sebastian Reichel <sre@...nel.org>, Chanwoo Choi <cw00.choi@...sung.com>,
 Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>, Pavel Machek <pavel@....cz>,
 Hans de Goede <hdegoede@...hat.com>,
 Marek Szyprowski <m.szyprowski@...sung.com>,
 Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>,
 Purism Kernel Team <kernel@...i.sm>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-input@...r.kernel.org,
 linux-leds@...r.kernel.org
Subject: Re: [PATCH v9 3/9] dt-bindings: power: supply: max17042: remove reg
 from required

On 02/12/2024 10:47, Dzmitry Sankouski wrote:
> Remove 'reg' property from required list, because in platform
> variant it should not be present, because i2c client is passed
> from MFD driver.
> 
> Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>

Sorry, not really. Device needs I2C address. I don't get what is
"platform variant" in terms of hardware, maybe you refer to some driver
changes. But anyway this needs proper hardware description, e.g. that
device does not have its own I2C address. If that's the case, of course.

Best regards,
Krzysztof