linux-kernel - Re: [RFC PATCH] sched: Fix integer overflow issue of cpu weight delta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241202104103.GN24400@noisy.programming.kicks-ass.net>
Date: Mon, 2 Dec 2024 11:41:03 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: I Hsin Cheng <richard120310@...il.com>
Cc: mingo@...hat.com, juri.lelli@...hat.com, vincent.guittot@...aro.org,
	dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
	mgorman@...e.de, vschneid@...hat.com, linux-kernel@...r.kernel.org,
	jserv@...s.ncku.edu.tw
Subject: Re: [RFC PATCH] sched: Fix integer overflow issue of cpu weight delta

On Mon, Dec 02, 2024 at 06:13:44PM +0800, I Hsin Cheng wrote:

> I think there's one point to concern, do we have a fixed range of
> "tg_weight()" ? 

kernel/sched/fair.c:__sched_group_set_shares()

  shares = clamp(shares, scale_load(MIN_SHARES), scale_load(MAX_SHARES));

  if (tg->shares == shares)
  	return 0;

  tg->shares = shares;