linux-kernel - Re: [PATCH v2 1/2] OPP: add index check to assert to avoid buffer overflow in _read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64dc6a89-7245-4546-a3e3-33bc2820388f@linaro.org>
Date: Mon, 2 Dec 2024 11:36:26 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
 Stephen Boyd <sboyd@...nel.org>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] OPP: add index check to assert to avoid buffer
 overflow in _read_freq()

On 02/12/2024 07:33, Viresh Kumar wrote:
> On 29-11-24, 16:06, Neil Armstrong wrote:
>> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
>> +static bool assert_single_clk(struct opp_table *opp_table, int __always_unused index)
> 
> Shouldn't the index be unsigned int here ?
> 

Yes, I'll respin a v3 with that.

Thanks,
Neil