linux-kernel - [tip: sched/core] sched: add READ_ONCE to task_on_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173313808465.412.17164013847284294134.tip-bot2@tip-bot2>
Date: Mon, 02 Dec 2024 11:14:44 -0000
From: "tip-bot2 for Harshit Agarwal" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Harshit Agarwal <harshit@...anix.com>,
 "Peter Zijlstra (Intel)" <peterz@...radead.org>, Phil Auld <pauld@...hat.com>,
 x86@...nel.org, linux-kernel@...r.kernel.org
Subject: [tip: sched/core] sched: add READ_ONCE to task_on_rq_queued

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     59297e2093ceced86393a059a4bd36802311f7bb
Gitweb:        https://git.kernel.org/tip/59297e2093ceced86393a059a4bd36802311f7bb
Author:        Harshit Agarwal <harshit@...anix.com>
AuthorDate:    Thu, 14 Nov 2024 14:08:11 -07:00
Committer:     Peter Zijlstra <peterz@...radead.org>
CommitterDate: Mon, 02 Dec 2024 12:01:30 +01:00

sched: add READ_ONCE to task_on_rq_queued

task_on_rq_queued read p->on_rq without READ_ONCE, though p->on_rq is
set with WRITE_ONCE in {activate|deactivate}_task and smp_store_release
in __block_task, and also read with READ_ONCE in task_on_rq_migrating.

Make all of these accesses pair together by adding READ_ONCE in the
task_on_rq_queued.

Signed-off-by: Harshit Agarwal <harshit@...anix.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
Reviewed-by: Phil Auld <pauld@...hat.com>
Link: https://lkml.kernel.org/r/20241114210812.1836587-1-jon@nutanix.com
---
 kernel/sched/sched.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 76f5f53..0f6790c 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -2271,7 +2271,7 @@ static inline int task_on_cpu(struct rq *rq, struct task_struct *p)
 
 static inline int task_on_rq_queued(struct task_struct *p)
 {
-	return p->on_rq == TASK_ON_RQ_QUEUED;
+	return READ_ONCE(p->on_rq) == TASK_ON_RQ_QUEUED;
 }
 
 static inline int task_on_rq_migrating(struct task_struct *p)