linux-kernel - Re: [PATCH] staging: gpib: Make GPIB_NI_PCI_ISA depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXOib-1DGZ=1wtNkMXocK1vtTN=s41J+Vh3uD56_MSEEw@mail.gmail.com>
Date: Mon, 2 Dec 2024 13:25:14 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Dave Penkler <dpenkler@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Arnd Bergmann <arnd@...db.de>, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gpib: Make GPIB_NI_PCI_ISA depend on HAS_IOPORT

On Sat, Nov 23, 2024 at 9:03 PM Nathan Chancellor <nathan@...nel.org> wrote:
> After commit 78ecb0375685 ("staging: gpib: make port I/O code
> conditional"), building tnt4882.ko on platforms without HAS_IOPORT (such
> as hexagon and s390) fails with:
>
>   ERROR: modpost: "inb_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
>   ERROR: modpost: "inw_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
>   ERROR: modpost: "nec7210_locking_ioport_write_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
>   ERROR: modpost: "nec7210_locking_ioport_read_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
>   ERROR: modpost: "outb_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
>   ERROR: modpost: "outw_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
>
> Only allow tnt4882.ko to be built when CONFIG_HAS_IOPORT is set to avoid
> this build failure, as this driver unconditionally needs it.
>
> Fixes: 78ecb0375685 ("staging: gpib: make port I/O code conditional")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>

Thanks, this fixes my Sun3+allmodconfig build.

Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds