linux-kernel - Re: [PATCH v6 08/12] arm64: dts: qcom: sdm845-starqltechn: add display PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABTCjFAUp9Oa_qRweO-EpLHDTi78=07i_St+L9EDSgYxHMrc4w@mail.gmail.com>
Date: Mon, 2 Dec 2024 16:18:00 +0300
From: Dzmitry Sankouski <dsankouski@...il.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: cros-qcom-dts-watchers@...omium.org, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 08/12] arm64: dts: qcom: sdm845-starqltechn: add
 display PMIC

пн, 4 нояб. 2024 г. в 17:15, Konrad Dybcio <konrad.dybcio@....qualcomm.com>:
>
> On 8.10.2024 6:51 PM, Dzmitry Sankouski wrote:
> > Add support for s2dos05 display / touchscreen PMIC
> >
> > Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
> > ---
> > Changes in v6:
> > - refactor: s/starqltechn/sdm845-starqltechn in subject
> > - refactor: 'i' < 'm', so put tlmm i2c node before motor*
>
> Now you have 'i'2c21 before 'g'pio-regulator :/

That refactor was about tlmm inner nodes. For soc nodes
rule `nodes of the same type can be grouped together` should apply I guess.
I think I should move it to regulators.

> [...]
>
> >
> > +     i2c21 {
> > +             compatible = "i2c-gpio";
>
> I'm not sure this has been asked before - is the GENI SE for I2C21
> disabled? Or are there reasons to use i2c-gpio instead?
>

I2c21 is wired on pins 127, 128, and those pins don't have a GENI SE function.

--
Best regards and thanks for review,
Dzmitry