linux-kernel - Re: [PATCH AUTOSEL 5.10 4/5] kselftest/arm64: Corrupt P0 in the irritator when testing SSVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z02iaXudPt42mby+@duo.ucw.cz>
Date: Mon, 2 Dec 2024 13:04:57 +0100
From: Pavel Machek <pavel@...x.de>
To: Sasha Levin <sashal@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Mark Brown <broonie@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>, will@...nel.org,
	shuah@...nel.org, mark.rutland@....com, thiago.bauermann@...aro.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.10 4/5] kselftest/arm64: Corrupt P0 in the
 irritator when testing SSVE

Hi!

> From: Mark Brown <broonie@...nel.org>
> 
> [ Upstream commit 3e360ef0c0a1fb6ce9a302e40b8057c41ba8a9d2 ]
> 
> When building for streaming SVE the irritator for SVE skips updates of both
> P0 and FFR. While FFR is skipped since it might not be present there is no
> reason to skip corrupting P0 so switch to an instruction valid in streaming
> mode and move the ifdef.

This is mismerged. Original patch moves #ifdef. How did AUTOSEL came
up with this?

Best regards,
								Pavel

> +++ b/tools/testing/selftests/arm64/fp/sve-test.S
> @@ -459,7 +459,8 @@ function irritator_handler
>  	movi	v9.16b, #2
>  	movi	v31.8b, #3
>  	// And P0
> -	rdffr	p0.b
> +	ptrue	p0.d
> +#ifndef SSVE
>  	// And FFR
>  	wrffr	p15.b
>  

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)