linux-kernel - Re: [PATCH v6 03/12] arm64: dts: qcom: sdm845-starqltechn: fix usb regulator mistake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABTCjFCTggnU7UvqcKYq53iRLACBxWE7C1TKRi7dr42o-=0Mqg@mail.gmail.com>
Date: Mon, 2 Dec 2024 16:41:00 +0300
From: Dzmitry Sankouski <dsankouski@...il.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: cros-qcom-dts-watchers@...omium.org, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 03/12] arm64: dts: qcom: sdm845-starqltechn: fix usb
 regulator mistake

сб, 26 окт. 2024 г. в 13:41, Konrad Dybcio <konrad.dybcio@....qualcomm.com>:
>
> On 8.10.2024 6:51 PM, Dzmitry Sankouski wrote:
> > Usb regulator was wrongly pointed to vreg_l1a_0p875.
> > However, on starqltechn it's powered from vreg_l5a_0p8.
> >
> > Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn")
> > Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
> >
> > ---
>
> I really really doubt that the supplies for on-SoC PHYs were altered,
> given these regulators are assigned based on their specific characteristics
>

>From rooted android system from klabit87 on starqltechn:

```
starqltechn:/ # cat /proc/cpuinfo | grep Hardware
Hardware        : Qualcomm Technologies, Inc SDM845
starqltechn:/ # uname -a
Linux localhost 4.9.186-klabitV6.5 #1 SMP PREEMPT Thu Dec 10 19:42:53
CST 2020 aarch64
starqltechn:/ # cat
/sys/kernel/debug/regulator/soc:rpmh-regulator-ldoa1-pm8998_l1/consumers
Device-Supply                    EN    Min_uV   Max_uV  load_uA
ae90000.qcom,dp_display-vdda-0p9 N     880000   880000        0
1d87000.ufsphy_mem-vdda-phy      Y     880000   880000    62900
ae96400.qcom,mdss_dsi_phy0-vdda-0p9 N          0        0        0
ae94400.qcom,mdss_dsi_phy0-vdda-0p9 Y     880000   880000    36000
1c00000.qcom,pcie-vreg-0.9       Y     880000   880000    24000
pm8998_l1                        N          0        0        0
starqltechn:/ # cat
/sys/kernel/debug/regulator/soc:rpmh-regulator-ldoa5-pm8998_l5/consumers
Device-Supply                    EN    Min_uV   Max_uV  load_uA
ae90000.qcom,dp_display-vdda-usb1-ss-core N          0        0        0
88e2000.qusb-vdd                 Y     800000   800000        0
88e8000.ssphy-vdd                Y     800000   800000        0
pm8998_l5                        N          0        0        0
```

I also downloaded kernel source from Samsung, to check its dts,
and it also powers qusb@...2000 and ssphy@...8000 from 'pm8998_l5' regulator.

-- 
Best regards and thanks for review,
Dzmitry