linux-kernel - Re: [PATCH] platform/x86: asus-wmi: Ignore return value when writing thermal policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58da1c4a-45ca-406b-9466-1186c0114cca@gmx.de>
Date: Mon, 2 Dec 2024 15:32:14 +0100
From: Armin Wolf <W_Armin@....de>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Hans de Goede <hdegoede@...hat.com>, auslands-kv@....de,
 corentin.chary@...il.com, luke@...nes.dev,
 platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wmi: Ignore return value when writing
 thermal policy

Am 02.12.24 um 15:29 schrieb Ilpo Järvinen:

> On Mon, 2 Dec 2024, Armin Wolf wrote:
>> Am 29.11.24 um 20:29 schrieb Armin Wolf:
>>> Am 25.11.24 um 10:39 schrieb Hans de Goede:
>>>> On 24-Nov-24 6:19 PM, Armin Wolf wrote:
>>>>> On some machines like the ASUS Vivobook S14 writing the thermal policy
>>>>> returns the currently writen thermal policy instead of an error code.
>>>>>
>>>>> Ignore the return code to avoid falsely returning an error when the
>>>>> thermal policy was written successfully.
>>>>>
>>>>> Reported-by: auslands-kv@....de
>>>>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219517
>>>>> Fixes: 2daa86e78c49 ("platform/x86: asus_wmi: Support throttle
>>>>> thermal policy")
>>>>> Signed-off-by: Armin Wolf <W_Armin@....de>
>>>> Thanks, patch looks good to me:
>>>>
>>>> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
>>>>
>>>> Regards,
>>>>
>>>> Hans
>>> I forgot to add the following tag:
>>>
>>> Tested-by: auslands-kv@....de
>>>
>>> Can we pick this patch for the next fixes pull?
>>>
>>> Thanks,
>>> Armin Wolf
>>>
>> Another user (Edoardo Brogiolo <brogioloedoardo@...il.com>) reported a similar
>> issue with another Asus machine,
>> see https://bbs.archlinux.org/viewtopic.php?id=301341 for details.
>>
>> Are there any blockers left for this patch to get accepted upstream?
> Hi Armin,
>
> I don't think there are any blocker I'm aware of. It's just that I'm
> extremely busy right after the merge window has closed as usual.
>
Ok, then i will just wait a bit.

Thanks,
Armin Wolf