[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <55d10cfc-fed7-489f-94e8-50a7568f5341@igalia.com>
Date: Mon, 2 Dec 2024 23:50:40 +0900
From: Changwoo Min <changwoo@...lia.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: tj@...nel.org, void@...ifault.com, mingo@...hat.com,
kernel-dev@...lia.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] sched_ext: Manage the validity of scx_rq_clock
Hello Peter,
On 24. 12. 2. 18:58, Peter Zijlstra wrote:
> On Mon, Dec 02, 2024 at 01:38:46PM +0900, Changwoo Min wrote:
>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>> index 95e40895a519..ab8015c8cab4 100644
>> --- a/kernel/sched/core.c
>> +++ b/kernel/sched/core.c
>> @@ -789,6 +789,7 @@ static void update_rq_clock_task(struct rq *rq, s64 delta)
>> void update_rq_clock(struct rq *rq)
>> {
>> s64 delta;
>> + u64 clock;
>>
>> lockdep_assert_rq_held(rq);
>>
>> @@ -800,11 +801,14 @@ void update_rq_clock(struct rq *rq)
>> SCHED_WARN_ON(rq->clock_update_flags & RQCF_UPDATED);
>> rq->clock_update_flags |= RQCF_UPDATED;
>> #endif
>> + clock = sched_clock_cpu(cpu_of(rq));
>> + scx_rq_clock_update(rq, clock);
>
> This adds a write to a second cacheline for *everyone* always.
>
> Please don't do that.
>
Thank you for the suggestion! I will update the flags only when
the scx is enabled by checking it inside the
scx_rq_clock_update() and scx_rq_clock_stale() functions.
Regards,
Changwoo Min
Powered by blists - more mailing lists