linux-kernel - Re: [PATCH v6 2/3] arm64: dts: qcom: move pon reboot-modes from pm8150.dtsi to board files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <264cd89c-317c-44e4-8db5-51a9190da04b@quicinc.com>
Date: Tue, 3 Dec 2024 10:53:47 +0800
From: Tingguo Cheng <quic_tingguoc@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: <quic_fenglinw@...cinc.com>, <quic_tingweiz@...cinc.com>,
        <kernel@...cinc.com>, <quic_eberman@...cinc.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 2/3] arm64: dts: qcom: move pon reboot-modes from
 pm8150.dtsi to board files



On 12/2/2024 6:12 PM, Dmitry Baryshkov wrote:
> On Mon, Dec 02, 2024 at 05:37:23PM +0800, Tingguo Cheng wrote:
>> Reboot modes were originally managed by PMIC pon driver on mobile/IoT
>> platforms, such as sm8150,sm8250,qdu1000... But recently, QCS615 is
>> going to adopt PSCI to manage linux reboot modes, which involves firm
>> wares to co-work with. In this case, reboot-modes should be removed
>> from pon dts node to avoid conflicting. This implies that reboot modes
>> go with devices rather than PMICs as well.
>>
>> Signed-off-by: Tingguo Cheng <quic_tingguoc@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/pm8150.dtsi                      | 2 --
>>   arch/arm64/boot/dts/qcom/qdu1000-idp.dts                  | 5 +++++
>>   arch/arm64/boot/dts/qcom/qrb5165-rb5.dts                  | 5 +++++
>>   arch/arm64/boot/dts/qcom/qru1000-idp.dts                  | 5 +++++
>>   arch/arm64/boot/dts/qcom/sm8150-hdk.dts                   | 5 +++++
>>   arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts | 5 +++++
>>   arch/arm64/boot/dts/qcom/sm8150-mtp.dts                   | 5 +++++
>>   arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi   | 5 +++++
>>   arch/arm64/boot/dts/qcom/sm8250-hdk.dts                   | 5 +++++
>>   arch/arm64/boot/dts/qcom/sm8250-mtp.dts                   | 5 +++++
>>   arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi      | 5 +++++
>>   arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi  | 5 +++++
>>   arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts           | 5 +++++
>>   13 files changed, 60 insertions(+), 2 deletions(-)
>>
> 
> Should the qcom-pon.c driver also be modified to skip registration in
> such a case? (Can be handled as a separate patch, no need to include it
> here / repost the series.)
Sure, we will consider this case in qcom-pon.c as a separate patch.
> 
> For the patch itself:
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> 

-- 
Thank you & BRs
Tingguo