linux-kernel - Re: [PATCH v30 28/30] ALSA: usb-audio: Add USB offload route kcontrol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a361446-7a18-4f49-9eeb-d60d1adaa088@intel.com>
Date: Tue, 3 Dec 2024 17:13:44 +0100
From: Cezary Rojewski <cezary.rojewski@...el.com>
To: Wesley Cheng <quic_wcheng@...cinc.com>
CC: <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-sound@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<linux-input@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <srinivas.kandagatla@...aro.org>,
	<mathias.nyman@...el.com>, <perex@...ex.cz>, <conor+dt@...nel.org>,
	<dmitry.torokhov@...il.com>, <corbet@....net>, <broonie@...nel.org>,
	<lgirdwood@...il.com>, <krzk+dt@...nel.org>,
	<pierre-louis.bossart@...ux.intel.com>, <Thinh.Nguyen@...opsys.com>,
	<tiwai@...e.com>, <robh@...nel.org>, <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v30 28/30] ALSA: usb-audio: Add USB offload route kcontrol

On 2024-11-06 8:34 PM, Wesley Cheng wrote:
> In order to allow userspace/applications know about USB offloading status,
> expose a sound kcontrol that fetches information about which sound card
> and PCM index the USB device is mapped to for supporting offloading.  In
> the USB audio offloading framework, the ASoC BE DAI link is the entity
> responsible for registering to the SOC USB layer.

...

R) += mixer_usb_offload.o
> diff --git a/sound/usb/mixer_usb_offload.c b/sound/usb/mixer_usb_offload.c
> new file mode 100644
> index 000000000000..e0689a3b9b86
> --- /dev/null
> +++ b/sound/usb/mixer_usb_offload.c
> @@ -0,0 +1,102 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2022-2024 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +#include <linux/usb.h>
> +
> +#include <sound/core.h>
> +#include <sound/control.h>
> +#include <sound/soc-usb.h>

ALSA-components should not be dependent on ASoC ones. It should be done 
the other way around: ALSA <- ASoC.

> +
> +#include "usbaudio.h"
> +#include "card.h"
> +#include "helper.h"
> +#include "mixer.h"
> +
> +#include "mixer_usb_offload.h"