linux-kernel - Re: [PATCH] modpost: Add .irqentry.text to OTHER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h67ku4ri.ffs@tglx>
Date: Tue, 03 Dec 2024 17:10:09 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>,
 20241015061522.25288-1-rui.zhang@...el.com, Zhang Rui
 <rui.zhang@...el.com>, hpa@...or.com, peterz@...radead.org,
 thorsten.blum@...lux.com, yuntao.wang@...ux.dev, tony.luck@...el.com,
 len.brown@...el.com, srinivas.pandruvada@...el.com,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org, mingo@...hat.com,
 bp@...en8.de, dave.hansen@...ux.intel.com, rafael.j.wysocki@...el.com,
 x86@...nel.org, linux-pm@...r.kernel.org, Nathan Chancellor
 <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>,
 linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] modpost: Add .irqentry.text to OTHER_SECTIONS

On Wed, Dec 04 2024 at 00:27, Masahiro Yamada wrote:
> On Tue, Dec 3, 2024 at 6:03 AM Thomas Gleixner <tglx@...utronix.de> wrote:
>> > In this mainline kernel, DEFINE_IDTENTRY_SYSVEC()
>> > expands to a normal .text function which is explicitly
>> > annotated 'noinline'.
>>
>> It's not annotated noinline, it's annotated 'noinstr', which puts the
>> code into the .noinstr.text section. That one is indeed covered.
>
> The callsite of local_apic_timer_interrupt() is annotated 'noinline'
> if I correctly understand this line:
>   https://github.com/torvalds/linux/blob/v6.13-rc1/arch/x86/include/asm/idtentry.h#L272

You're right. I got lost in the macro maze and looked at the actual
sysvec_...() part.

>> So yes, the fix is only required for pre 5.8 kernels.
>
> This never occurs on x86 after commit f0178fc01fe46,
> but theoretically this may occur for other architectures.

Correct.

Thanks,

        tglx