linux-kernel - RE: [PATCH v5 1/2] kexec: Consolidate machine_kexec_mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ed2ou3is.ffs@tglx>
Date: Tue, 03 Dec 2024 17:36:59 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: "Farber, Eliav" <farbere@...zon.com>, "linux@...linux.org.uk"
 <linux@...linux.org.uk>, "catalin.marinas@....com"
 <catalin.marinas@....com>, "will@...nel.org" <will@...nel.org>,
 "mpe@...erman.id.au" <mpe@...erman.id.au>, "npiggin@...il.com"
 <npiggin@...il.com>, "christophe.leroy@...roup.eu"
 <christophe.leroy@...roup.eu>, "naveen@...nel.org" <naveen@...nel.org>,
 "maddy@...ux.ibm.com" <maddy@...ux.ibm.com>, "paul.walmsley@...ive.com"
 <paul.walmsley@...ive.com>, "palmer@...belt.com" <palmer@...belt.com>,
 "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
 "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, "bhe@...hat.com"
 <bhe@...hat.com>, "hbathini@...ux.ibm.com" <hbathini@...ux.ibm.com>,
 "sourabhjain@...ux.ibm.com" <sourabhjain@...ux.ibm.com>,
 "adityag@...ux.ibm.com" <adityag@...ux.ibm.com>,
 "songshuaishuai@...ylab.org" <songshuaishuai@...ylab.org>,
 "takakura@...inux.co.jp" <takakura@...inux.co.jp>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org"
 <linuxppc-dev@...ts.ozlabs.org>, "linux-riscv@...ts.infradead.org"
 <linux-riscv@...ts.infradead.org>
Cc: "Chocron, Jonathan" <jonnyc@...zon.com>
Subject: RE: [PATCH v5 1/2] kexec: Consolidate
 machine_kexec_mask_interrupts() implementation

On Tue, Dec 03 2024 at 12:55, Eliav Farber wrote:
> On 12/3/2024 1:04 PM, Thomas Gleixner wrote:
>>> +
>>> +config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD
>>> +     bool "Clear forwarded VM interrupts during kexec"
>>
>> This should not be user selectable. Just keep it as:
>>
>> config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD
>>         bool
>>
>> which defaults to 'n'. Just add a comment what this is about like it's
>> done with the other options in that file which are only selectable.
> Question: Should this new configuration option be placed inside or
> outside the following section:
> ```
> menu "IRQ subsystem"
>
>
> endmenu
> ```
> In my patch, I have added the new configuration option at the end of
> the file, outside the "IRQ subsystem" section.

It does not really matter when the option is silent, but keeping it in
the menu section as the others is the most intuitive IMO.

Thanks,

        tglx