linux-kernel - Re: [PATCH RESEND v1] mm/memory_hotplug: move debug_pagealloc_map_pages() into online_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z08jp0KSh6Hw_eJt@localhost.localdomain>
Date: Tue, 3 Dec 2024 16:28:39 +0100
From: Oscar Salvador <osalvador@...e.de>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH RESEND v1] mm/memory_hotplug: move
 debug_pagealloc_map_pages() into online_pages_range()

On Tue, Dec 03, 2024 at 11:20:50AM +0100, David Hildenbrand wrote:
> In the near future, we want to have a single way to handover PageOffline
> pages to the buddy, whereby they could have:
> 
> (a) Never been exposed to the buddy before: kept PageOffline when onlining
>     the memory block.
> (b) Been allocated from the buddy, for example using
>     alloc_contig_range() to then be set PageOffline,
> 
> Let's start by making generic_online_page() less special compared to

This got me confused for a moment. I'd have said "making
__free_pages_core" less special? As that is where we were calling 
debug_pagealloc_map_pages() if the context  on the context.

> ordinary page freeing (e.g., free_contig_range()), and perform the
> debug_pagealloc_map_pages() call unconditionally, even when the online
> callback might decide to keep the pages offline.
> 
> All pages are already initialized with PageOffline, so nobody touches
> them either way.
> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Oscar Salvador <osalvador@...e.de>
> Signed-off-by: David Hildenbrand <david@...hat.com>

Acked-by: Oscar Salvador <osalvador@...e.de>


-- 
Oscar Salvador
SUSE Labs