linux-kernel - Re: [PATCH 2/2] gpio: omap: save two lines by using devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34ab5f0b78c2869cc43797a72d6a2f40d9b246f3.camel@siemens.com>
Date: Tue, 3 Dec 2024 18:19:48 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "ssantosh@...nel.org" <ssantosh@...nel.org>, "brgl@...ev.pl"
	<brgl@...ev.pl>, "khilman@...nel.org" <khilman@...nel.org>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"grygorii.strashko@...com" <grygorii.strashko@...com>
CC: "bartosz.golaszewski@...aro.org" <bartosz.golaszewski@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 2/2] gpio: omap: save two lines by using
 devm_clk_get_prepared()

On Tue, 2024-12-03 at 17:41 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> We can drop the else branch if we get the clock already prepared using
> the relevant helper.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...il.com>

> ---
>  drivers/gpio/gpio-omap.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index 54c4bfdccf568..57d299d5d0b16 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1449,13 +1449,11 @@ static int omap_gpio_probe(struct platform_device *pdev)
>  	}
>  
>  	if (bank->dbck_flag) {
> -		bank->dbck = devm_clk_get(dev, "dbclk");
> +		bank->dbck = devm_clk_get_prepared(dev, "dbclk");
>  		if (IS_ERR(bank->dbck)) {
>  			dev_err(dev,
>  				"Could not get gpio dbck. Disable debounce\n");
>  			bank->dbck_flag = false;
> -		} else {
> -			clk_prepare(bank->dbck);
>  		}
>  	}

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com