linux-kernel - Re: [PATCH 0/3] drm/msm/dp: Fix and utilize TPG with a debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8bb9597-c5b3-4dbf-a65e-7bd17cd3ffc5@quicinc.com>
Date: Tue, 3 Dec 2024 11:42:42 -0800
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
        "Marijn
 Suijten" <marijn.suijten@...ainline.org>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Stephen Boyd <swboyd@...omium.org>,
        "Kuogee
 Hsieh" <quic_khsieh@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        Jessica Zhang <quic_jesszhan@...cinc.com>
Subject: Re: [PATCH 0/3] drm/msm/dp: Fix and utilize TPG with a debugfs



On 12/3/2024 6:31 AM, Dmitry Baryshkov wrote:
> On Mon, Dec 02, 2024 at 12:41:57PM -0800, Abhinav Kumar wrote:
>> DP Test Patten Generator is a very useful tool to debug issues such
>> as blank screen or corruption seen on the DP monitor by isolating it
>> to whether the corruption is coming from further upstream such as DPU
>> OR from the DP controller and below. It was noted in [1] that this API
>> is unused. Rather than dropping the API, it should be fixed and used.
>>
>> Hence, this series fixes the DP Test Patten Generator API and also utilizes
>> it by adding a debugfs for it.
>>
>> [1] : https://patchwork.freedesktop.org/patch/623508/?series=141074&rev=1
> 
> I'd prefer for this to be rebased on top of [2]. The series has been
> posted a month ago.
> 
> [2] https://patchwork.freedesktop.org/series/141074/
> 

Well, the review of that series which tried dropping the tpg led to this 
one really.

I will review that one within a couple of days. Lets first agree on that 
series before deciding to rebase.

>>
>> To: Rob Clark <robdclark@...il.com>
>> To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>> To: Sean Paul <sean@...rly.run>
>> To: Marijn Suijten <marijn.suijten@...ainline.org>
>> To: David Airlie <airlied@...il.com>
>> To: Simona Vetter <simona@...ll.ch>
>> To: Stephen Boyd <swboyd@...omium.org>
>> To: Kuogee Hsieh <quic_khsieh@...cinc.com>
>> Cc: linux-arm-msm@...r.kernel.org
>> Cc: dri-devel@...ts.freedesktop.org
>> Cc: freedreno@...ts.freedesktop.org
>> Cc: linux-kernel@...r.kernel.org
>> Cc: Jessica Zhang <quic_jesszhan@...cinc.com>
>>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@...cinc.com>
>> ---
>> Abhinav Kumar (3):
>>        drm/msm/dp: account for widebus in msm_dp_catalog_panel_tpg_enable()
>>        drm/msm/dp: do not touch the MMSS_DP_INTF_CONFIG for tpg
>>        drm/msm/dp: add a debugfs node for using tpg
>>
>>   drivers/gpu/drm/msm/dp/dp_catalog.c | 15 +++++++--
>>   drivers/gpu/drm/msm/dp/dp_debug.c   | 61 +++++++++++++++++++++++++++++++++++++
>>   drivers/gpu/drm/msm/dp/dp_panel.h   |  2 ++
>>   3 files changed, 76 insertions(+), 2 deletions(-)
>> ---
>> base-commit: 798bb342e0416d846cf67f4725a3428f39bfb96b
>> change-id: 20241202-tpg-3f7543c036ac
>>
>> Best regards,
>> -- 
>> Abhinav Kumar <quic_abhinavk@...cinc.com>
>>
>