linux-kernel - Re: [PATCH v5 4/5] media: uvcvideo: Remove redundant NULL assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241203202733.GA21544@pendragon.ideasonboard.com>
Date: Tue, 3 Dec 2024 22:27:33 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Hans de Goede <hdegoede@...hat.com>
Cc: Ricardo Ribalda <ribalda@...omium.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Guennadi Liakhovetski <guennadi.liakhovetski@...el.com>,
	Hans Verkuil <hverkuil@...all.nl>,
	Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/5] media: uvcvideo: Remove redundant NULL assignment

On Mon, Dec 02, 2024 at 03:44:57PM +0100, Hans de Goede wrote:
> On 2-Dec-24 3:24 PM, Ricardo Ribalda wrote:
> > ctrl->handle will only be different than NULL for controls that have
> > mappings. This is because that assignment is only done inside
> > uvc_ctrl_set() for mapped controls.
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> 
> Thanks, patch looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>

This should come before 2/5, otherwise that patch will be wrong about
the documented locking rule. I'm also fine with squashing this change in
2/5 (with an update to the commit message).

> > ---
> >  drivers/media/usb/uvc/uvc_ctrl.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
> > index 576e3854be91..e90bf2aeb5e4 100644
> > --- a/drivers/media/usb/uvc/uvc_ctrl.c
> > +++ b/drivers/media/usb/uvc/uvc_ctrl.c
> > @@ -1672,10 +1672,8 @@ bool uvc_ctrl_status_event_async(struct urb *urb, struct uvc_video_chain *chain,
> >  	struct uvc_device *dev = chain->dev;
> >  	struct uvc_ctrl_work *w = &dev->async_ctrl;
> >  
> > -	if (list_empty(&ctrl->info.mappings)) {
> > -		ctrl->handle = NULL;
> > +	if (list_empty(&ctrl->info.mappings))
> >  		return false;
> > -	}
> >  
> >  	w->data = data;
> >  	w->urb = urb;
> > 

-- 
Regards,

Laurent Pinchart