linux-kernel - Re: [RFC PATCH 01/15] irqchip/riscv-imsic: Use hierarchy to reach irq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874j3ktrjv.ffs@tglx>
Date: Tue, 03 Dec 2024 21:55:32 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Anup Patel <anup@...infault.org>
Cc: Andrew Jones <ajones@...tanamicro.com>, iommu@...ts.linux.dev,
 kvm-riscv@...ts.infradead.org, kvm@...r.kernel.org,
 linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
 tjeznach@...osinc.com, zong.li@...ive.com, joro@...tes.org,
 will@...nel.org, robin.murphy@....com, atishp@...shpatra.org,
 alex.williamson@...hat.com, paul.walmsley@...ive.com, palmer@...belt.com,
 aou@...s.berkeley.edu
Subject: Re: [RFC PATCH 01/15] irqchip/riscv-imsic: Use hierarchy to reach
 irq_set_affinity

On Tue, Dec 03 2024 at 22:07, Anup Patel wrote:
> On Tue, Dec 3, 2024 at 7:23 PM Thomas Gleixner <tglx@...utronix.de> wrote:
>> Sorry, I missed that when reviewing the original IMSIC MSI support.
>>
>> The whole IMSIC MSI support can be moved over to MSI LIB which makes all
>> of this indirection go away and your intermediate domain will just fit
>> in.
>>
>> Uncompiled patch below. If that works, it needs to be split up properly.
>>
>> Note, this removes the setup of the irq_retrigger callback, but that's
>> fine because on hierarchical domains irq_chip_retrigger_hierarchy() is
>> invoked anyway. See try_retrigger().
>
> The IMSIC driver was merged one kernel release before common
> MSI LIB was merged.

Ah indeed.

> We should definitely update the IMSIC driver to use MSI LIB, I will
> try your suggested changes (below) and post a separate series.

Pick up the delta patch I gave Andrew...