| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20241203-uvc-fix-async-v6-4-26c867231118@chromium.org> Date: Tue, 03 Dec 2024 21:20:11 +0000 From: Ricardo Ribalda <ribalda@...omium.org> To: Laurent Pinchart <laurent.pinchart@...asonboard.com>, Hans de Goede <hdegoede@...hat.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Guennadi Liakhovetski <guennadi.liakhovetski@...el.com> Cc: Hans Verkuil <hverkuil@...all.nl>, Mauro Carvalho Chehab <mchehab+samsung@...nel.org>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, Ricardo Ribalda <ribalda@...omium.org> Subject: [PATCH v6 4/5] media: uvcvideo: Annotate lock requirements for uvc_ctrl_set Make it explicit that the function is always called with ctrl_mutex being held. Suggested-by: Laurent Pinchart <laurent.pinchart@...asonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com> Reviewed-by: Hans de Goede <hdegoede@...hat.com> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org> --- drivers/media/usb/uvc/uvc_ctrl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index def502195528..3dc9b7a49f64 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1981,6 +1981,8 @@ int uvc_ctrl_set(struct uvc_fh *handle, s32 max; int ret; + lockdep_assert_held(&chain->ctrl_mutex); + if (__uvc_query_v4l2_class(chain, xctrl->id, 0) >= 0) return -EACCES; -- 2.47.0.338.g60cca15819-goog
Powered by blists - more mailing lists