linux-kernel - Re: [PATCH 1/2] gpio: omap: allow building the module with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37f90519-48e9-4caa-80c6-9f6ae61aae0a@ti.com>
Date: Tue, 3 Dec 2024 15:54:39 -0600
From: Andrew Davis <afd@...com>
To: Bartosz Golaszewski <brgl@...ev.pl>
CC: Linus Walleij <linus.walleij@...aro.org>,
        Santosh Shilimkar
	<ssantosh@...nel.org>,
        Kevin Hilman <khilman@...nel.org>,
        Alexander Sverdlin
	<alexander.sverdlin@...mens.com>,
        <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>,
        Bartosz
 Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 1/2] gpio: omap: allow building the module with
 COMPILE_TEST=y

On 12/3/24 2:36 PM, Bartosz Golaszewski wrote:
> On Tue, Dec 3, 2024 at 7:41 PM Andrew Davis <afd@...com> wrote:
>>
>> On 12/3/24 10:41 AM, Bartosz Golaszewski wrote:
>>> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>>>
>>> For better build coverage, allow building the gpio-omap driver with
>>> COMPILE_TEST Kconfig option enabled.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>>> ---
>>>    drivers/gpio/Kconfig | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>>> index 56fee58e281e7..fb923ccd79028 100644
>>> --- a/drivers/gpio/Kconfig
>>> +++ b/drivers/gpio/Kconfig
>>> @@ -530,7 +530,7 @@ config GPIO_OCTEON
>>>    config GPIO_OMAP
>>>        tristate "TI OMAP GPIO support" if ARCH_OMAP2PLUS || COMPILE_TEST
>>>        default y if ARCH_OMAP
>>> -     depends on ARM
>>> +     depends on ARM || COMPILE_TEST
>>
>> Why do we have this depends on ARM at all? It already has that condition
>> above on ARCH_OMAP2PLUS which limits to ARM outside of compile testing.
>>
>> And anything that selects ARCH_OMAP2PLUS also selects ARCH_OMAP, so we
>> could just do this:
>>
> 
> I agree we can drop that bit.
> 
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -528,9 +528,9 @@ config GPIO_OCTEON
>>             family of SOCs.
>>
>>    config GPIO_OMAP
>> -       tristate "TI OMAP GPIO support" if ARCH_OMAP2PLUS || COMPILE_TEST
>> -       default y if ARCH_OMAP
>> -       depends on ARM
>> +       tristate "TI OMAP GPIO support"
>> +       default y
>> +       depends on ARCH_OMAP2PLUS || COMPILE_TEST
> 
> This would default to y with COMPILE_TEST. We definitely don't want
> that. IMO it should be:
> 
> tristate "TI OMAP GPIO support"
> depends on ARCH_OMAP2PLUS || COMPILE_TEST
> default y if ARCH_OMAP2PLUS
> 

Looks good to me

Andrew