linux-kernel - Re: [PATCH 1/1 perf-tools] perf machine: Initialize machine->env to address a segfault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173326311856.2683269.6372380713007833609.b4-ty@kernel.org>
Date: Tue, 03 Dec 2024 13:58:38 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Veronika Molnarova <vmolnaro@...hat.com>, 
 Adrian Hunter <adrian.hunter@...el.com>, Ian Rogers <irogers@...gle.com>, 
 James Clark <james.clark@...aro.org>, Jiri Olsa <jolsa@...nel.org>, 
 Kan Liang <kan.liang@...ux.intel.com>, Michael Petlan <mpetlan@...hat.com>, 
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
 linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/1 perf-tools] perf machine: Initialize machine->env
 to address a segfault

On Tue, 26 Nov 2024 11:47:25 -0300, Arnaldo Carvalho de Melo wrote:

> Its used from trace__run(), for the 'perf trace' live mode, i.e. its
> strace-like, non-perf.data file processing mode, the most common one.
> 
> The trace__run() function will set trace->host using machine__new_host()
> that is supposed to give a machine instance representing the running
> machine, and since we'll use perf_env__arch_strerrno() to get the right
> errno -> string table, we need to use machine->env, so initialize it in
> machine__new_host().
> 
> [...]

Applied to perf-tools, thanks!

Best regards,
Namhyung