linux-kernel - Re: [PATCH v3 DONOTMERGE] docs: clarify rules wrt tagging other people

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd47620e-d2bd-48f5-8e40-555d6ddf921e@leemhuis.info>
Date: Tue, 3 Dec 2024 07:25:43 +0100
From: Thorsten Leemhuis <linux@...mhuis.info>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: Jonathan Corbet <corbet@....net>, workflows@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Simona Vetter <simona.vetter@...ll.ch>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v3 DONOTMERGE] docs: clarify rules wrt tagging other
 people

On 02.12.24 17:17, Mauro Carvalho Chehab wrote:
> Em Mon, 2 Dec 2024 16:54:49 +0100
> Thorsten Leemhuis <linux@...mhuis.info> escreveu:
>> On 02.12.24 15:45, Mauro Carvalho Chehab wrote:
>>> Em Mon, 2 Dec 2024 14:54:56 +0100
>>> Thorsten Leemhuis <linux@...mhuis.info> escreveu:
>>>> On 02.12.24 11:02, Mauro Carvalho Chehab wrote:  
>>>>> Em Mon, 2 Dec 2024 09:28:57 +0100
>>>>> Mauro Carvalho Chehab <mchehab+huawei@...nel.org> escreveu:
>>>>>>> +Tagging people requires permission
>>>>>>> +----------------------------------
>>>>>>> +
>>>>>>> +Be careful in the addition of tags to your patches, as all except for Cc:,
>>>>>>> +Reported-by:, and Suggested-by: need explicit permission of the person named.
>>>>>
>>>>> Hmm... There is another tag that we use without requiring explicit permissions:
>>>>>
>>>>> 	Requested-by:
>>>>>
>>>>> There are currently 376 occurrences on 6.13-rc1.
>>>>>
>>>>> This is used when a maintainer or reviewer publicly requests some changes to
>>>>> be added on a patch series.    
>>> [...]
>>> You're basically requesting explicit permission for any "non-official"
>>> tags as well, including reviewed-by. This is not what it is wanted here.  
>>
>> I could easily use a slightly modified phrase like "...as all
>> mentioned above except...".
> 
> It seems a lot better to me.

I went with this a slightly different variant for readability:

Be careful in the addition of the aforementioned tags to your patches,
as all except for Cc:, Reported-by:, and Suggested-by: need explicit
permission of the person named.

Hope that's okay. If I don't hear anything, I'll assume your earlier
Reviewed-by: is still valid.

Ciao, Thorsten