linux-kernel - Re: [RFC PATCH] resource: Fix CXL node not populated issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87frn5wac3.fsf@DESKTOP-5N7EMDA>
Date: Tue, 03 Dec 2024 14:26:52 +0800
From: "Huang, Ying" <ying.huang@...ux.alibaba.com>
To: Raghavendra K T <raghavendra.kt@....com>
Cc: <linux-kernel@...r.kernel.org>,  <linux-cxl@...r.kernel.org>,
  <bharata@....com>,  Andrew Morton <akpm@...ux-foundation.org>,  "Dan
 Williams" <dan.j.williams@...el.com>,  David Hildenbrand
 <david@...hat.com>,  Davidlohr Bueso <dave@...olabs.net>,  Jonathan
 Cameron <jonathan.cameron@...wei.com>,  Dave Jiang <dave.jiang@...el.com>,
  "Alison Schofield" <alison.schofield@...el.com>,  Vishal Verma
 <vishal.l.verma@...el.com>,  Ira Weiny <ira.weiny@...el.com>,  Alistair
 Popple <apopple@...dia.com>,  Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>,  Bjorn Helgaas <bhelgaas@...gle.com>,
  Baoquan He <bhe@...hat.com>,  <ilpo.jarvinen@...ux.intel.com>,  Mika
 Westerberg <mika.westerberg@...ux.intel.com>,  Fontenot Nathan
 <Nathan.Fontenot@....com>,  Wei Huang <wei.huang2@....com>
Subject: Re: [RFC PATCH] resource: Fix CXL node not populated issue

Raghavendra K T <raghavendra.kt@....com> writes:

> Before:
> ~]$ numastat -m
> ...
>                           Node 0          Node 1           Total
>                  --------------- --------------- ---------------
> MemTotal               128096.18       128838.48       256934.65
>
> After:
> $ numastat -m
> .....
>                           Node 0          Node 1          Node 2           Total
>                  --------------- --------------- --------------- ---------------
> MemTotal               128054.16       128880.51       129024.00       385958.67
>
> Current patch reverts the effect of first commit where the issue is seen.

This doesn't root cause the issue.  Please trace the code path
(e.g. return value of region_intersects(), in which code path) at least.
Without these information, we cannot come up with a proper fix to your issue.

> git bisect had led to below commit
> Fixes: b4afe4183ec7 ("resource: fix region_intersects() vs add_memory_driver_managed()")

This breaks you case, sorry about that.  But this also fixed a real bug
too.  So, it's not appropriate just to revert it blindly.

[snip]

---
Best Regards,
Huang, Ying