linux-kernel - Re: [PATCH V2 1/2] usb: typec: tcpm: tcpci: Make the driver be compatible with the TCPCI spec [Rev 2.0 Ver 1.0, October 2017]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2024120332-flashcard-walnut-e57a@gregkh>
Date: Tue, 3 Dec 2024 08:40:47 +0100
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: Miao Zhu <Miao.Zhu@...opsys.com>
Cc: "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
	"andre.draszik@...aro.org" <andre.draszik@...aro.org>,
	"rdbabiera@...gle.com" <rdbabiera@...gle.com>,
	"m.felsch@...gutronix.de" <m.felsch@...gutronix.de>,
	"u.kleine-koenig@...libre.com" <u.kleine-koenig@...libre.com>,
	"dan.carpenter@...aro.org" <dan.carpenter@...aro.org>,
	"emanuele.ghidoli@...adex.com" <emanuele.ghidoli@...adex.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jianheng Zhang <Jianheng.Zhang@...opsys.com>
Subject: Re: [PATCH V2 1/2] usb: typec: tcpm: tcpci: Make the driver be
 compatible with the TCPCI spec [Rev 2.0 Ver 1.0, October 2017]

On Tue, Dec 03, 2024 at 01:08:39AM +0000, Miao Zhu wrote:
> The tcpci driver doesn't fully follow the TCPCI spec even if
> it mentions this spec in its comments.
> - Add two flags into tcpci_data:
>                 RX_BUF_BYTE_x_hidden
>                 conn_present_capable
> - Following flags in tcpci_data are read from device tree in tcpci_probe.
>                 TX_BUF_BYTE_x_hidden
>                 RX_BUF_BYTE_x_hidden
>                 auto_discharge_disconnect
>                 vbus_vsafe0v
> The change makes the driver be compatible with the TCPCI spec and
> therefore won't impact existing HW.
> 
> Signed-off-by: Miao Zhu Miao.Zhu@...opsys.com<mailto:Miao.Zhu@...opsys.com>
> ---
> V1 -> V2: Cleaned up typo and addressed review comments

HTML patches obviously can't be applied :(