linux-kernel - Re: [PATCH] drivers/media/pci/sta2x11: replace legacy GPIO APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f552e0f5-6350-416f-89e5-e1a0e6aa2886@189.cn>
Date: Tue, 3 Dec 2024 15:48:19 +0800
From: Song Chen <chensong_2000@....cn>
To: Arnd Bergmann <arnd@...db.de>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, Hans Verkuil <hverkuil-cisco@...all.nl>
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH] drivers/media/pci/sta2x11: replace legacy GPIO APIs

ok, then remove it.

what about drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c,
it has the same problem, are you going to remove it as well?

Song

在 2024/12/3 15:32, Arnd Bergmann 写道:
> On Tue, Dec 3, 2024, at 08:27, Song Chen wrote:
>> GPIO subsystem is moving toward a descriptor-based approach
>> from global GPIO numberspace, but some of legacy GPIO APIs
>> callings still remain in sta2x11.
>>
>> This patch mainly replaces gpio_request with gpiod_get_index
>> and removes including gpio.h.
>>
>> Signed-off-by: Song Chen <chensong_2000@....cn>
>> ---
> 
> This is a step in the right direction, but realistically we
> should just remove this driver. I'm planning to send a patch
> to remove the sta2x11 platform from arch/x86 in a few days
> as we had discussed years ago but never actually done.
> 
>        Arnd
>