linux-kernel - Re: [PATCH] i2c: omap: Cleaned up coding style and parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z066SMd4XjNLd_Wt@melbuntu>
Date: Tue, 3 Dec 2024 13:29:04 +0530
From: Dhruv Menon <dhruvmenon1104@...il.com>
To: Andreas Kemnade <andreas@...nade.info>
Cc: Aaro Koskinen <aaro.koskinen@....fi>, vigneshr@...com,
	andi.shyti@...nel.org, jmkrzyszt@...il.com, tony@...mide.com,
	khilman@...libre.com, rogerq@...nel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: omap: Cleaned up coding style and parameters

> > Not sure if that is correct as sleeps can be now shorter? I wouldn't
> > touch them unless you can show some real benefit (checkpatch.pl warning
> > isn't one for old driver code).
> > 
> The sleeps are not shorter, instead possibly longer. I do not think
> that is an issue, AFAIK the idea with sleep range is to bundle wakeups
> and reduce power consumption.
> 
As per timer,how-to docs present, using ms_sleep(1) will 
lead longer sleep time (about 20ms in HZ=100)

> > Maybe also changes should be split into separate patches for easier
> > review.
> > 
> I would leave out omap_i2c_*data() parameter stuff until the i2c irq
> regressions are fixed, maybe that parameter is needed.
> 
Using git blame, the only usage of it has been for error logging.

On Tue, Dec 03, 2024 at 08:35:47AM +0100, Andreas Kemnade wrote:
> Am Mon, 2 Dec 2024 22:58:17 +0200
> schrieb Aaro Koskinen <aaro.koskinen@....fi>:
> 
> > On Tue, Dec 03, 2024 at 12:22:51AM +0530, Dhruv Menon wrote:
> > > This commit addresses the coding style issues present in i2c-omap.c,
> > > identified by checkpatch.pl and removes unused parameters present in
> > > two functions.
> > > 
> > > 1. Coding style issues includes Macro Utilization, alignnment
> > >    correction, updating ms_sleep() < 20 to usleep_range().
> > > 2. Removed unused parameters from omap_i2c_receive_data()
> > >    and omap_i2c_transmit_data().
> > > 
> > > No functional changes have been introduced in this commit.  
> > 
> > Not sure if that is correct as sleeps can be now shorter? I wouldn't
> > touch them unless you can show some real benefit (checkpatch.pl warning
> > isn't one for old driver code).
> > 
> The sleeps are not shorter, instead possibly longer. I do not think
> that is an issue, AFAIK the idea with sleep range is to bundle wakeups
> and reduce power consumption.
> 
> > Maybe also changes should be split into separate patches for easier
> > review.
> > 
> I would leave out omap_i2c_*data() parameter stuff until the i2c irq
> regressions are fixed, maybe that parameter is needed.
> 
> Regards,
> Andreas