linux-kernel - Re: [PATCH] iio: kx022a: document new chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <y6intisaqsyfvyvmkgzmeyojc3punimy3uhtp6a25gm4tn77yc@oikj64bmtebt>
Date: Tue, 3 Dec 2024 10:39:58 +0100
From: Mehdi Djait <mehdi.djait@...ux.intel.com>
To: Matti Vaittinen <mazziesaccount@...il.com>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>, 
	Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: kx022a: document new chip_info structure members

Hi Matti,

> > >   drivers/iio/accel/kionix-kx022a.h | 5 +++++
> > >   1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/drivers/iio/accel/kionix-kx022a.h b/drivers/iio/accel/kionix-kx022a.h
> > > index 142652ff4b22..82c4ced7426d 100644
> > > --- a/drivers/iio/accel/kionix-kx022a.h
> > > +++ b/drivers/iio/accel/kionix-kx022a.h
> > > @@ -137,6 +137,11 @@ struct kx022a_data;
> > >    *
> > >    * @name:			name of the device
> > >    * @regmap_config:		pointer to register map configuration
> > > + * scale_table:			Array of two integer tables containing
> > > + *				supported scales. Each scale is represented
> > > + *				a 2 value array. First value being full
> > > + *				integers, second being NANOs.
> > 
> > How about:
> > 
> > Array of tables containing two scaling factors for the supported
> > acceleration measurement ranges. First value is the integer part and
> > second value is the fractional part in nano units.
> > 
> 
> Hi Mehdi. Thanks for the input. I definitely prefer your wording over what I
> wrote. Except maybe the note about each table containing two scaling
> factors. I think a table contains two integers, but only one scaling factor
> which is composed of those integers.
> 

that is true, it is just one scaling factor.

> I am also still wondering if ppb (or even fully written "parts per billion")
> should be used instead of nano. In my ears the "nano" needs units, but I
> suppose the scale does not have any.
> 

So how about:
Array of tables containing a scaling factor for the supported
acceleration measurement range. First value is the integer part and
second value is the nano fractional part.

or:
Array of tables containing a scaling factor for the supported
acceleration measurement range. First value is the integer part and
second value is the nano/ppb (parts per billion) fractional part.

> Yours,
> 	-- Matti

--
Kind Regards
Mehdi Djait