linux-kernel - Re: [PATCH v2 1/1] fs/qnx6: Fix building with GCC 15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241203-syndikat-jazzfest-f99972a88933@brauner>
Date: Tue, 3 Dec 2024 10:41:31 +0100
From: Christian Brauner <brauner@...nel.org>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: Brahmajit Das <brahmajit.xyz@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] fs/qnx6: Fix building with GCC 15

On Fri, Nov 15, 2024 at 05:03:58AM +0000, Al Viro wrote:
> On Sat, Oct 05, 2024 at 01:21:32AM +0530, Brahmajit Das wrote:
> > qnx6_checkroot() had been using weirdly spelled initializer - it needed
> > to initialize 3-element arrays of char and it used NUL-padded
> > 3-character string literals (i.e. 4-element initializers, with
> > completely pointless zeroes at the end).
> > 
> > That had been spotted by gcc-15[*]; prior to that gcc quietly dropped
> > the 4th element of initializers.
> > 
> > However, none of that had been needed in the first place - all this
> > array is used for is checking that the first directory entry in root
> > directory is "." and the second - "..".  The check had been expressed as
> > a loop, using that match_root[] array.  Since there is no chance that we
> > ever want to extend that list of entries, the entire thing is much too
> > fancy for its own good; what we need is just a couple of explicit
> > memcmp() and that's it.
> > 
> > [*]: fs/qnx6/inode.c: In function ‘qnx6_checkroot’:
> > fs/qnx6/inode.c:182:41: error: initializer-string for array of ‘char’ is too long [-Werror=unterminated-string-initialization]
> >   182 |         static char match_root[2][3] = {".\0\0", "..\0"};
> >       |                                         ^~~~~~~
> > fs/qnx6/inode.c:182:50: error: initializer-string for array of ‘char’ is too long [-Werror=unterminated-string-initialization]
> >   182 |         static char match_root[2][3] = {".\0\0", "..\0"};
> >       |                                                  ^~~~~~
> > 
> > Signed-off-by: Brahmajit Das <brahmajit.xyz@...il.com>
> 
> Acked-by: Al Viro <viro@...iv.linux.org.uk>
> 
> Sorry, hadn't realized it had fallen through the cracks.
> Christian, usually you are handling vfs/vfs.git#vfs.misc; I can put
> it there myself, if you prefer it that way...

I've put it into vfs.fixes for rc2 as it's a bugfix. I didn't see you
wrote me message smh. Sorry.