linux-kernel - Re: [RESEND] macintosh: Fix spelling mistake "toogle" to "toggle"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fecc5d0f-0e84-4a77-bc1e-934e54037724@csgroup.eu>
Date: Tue, 3 Dec 2024 10:19:46 +0100
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Zhu Jun <zhujun2@...s.chinamobile.com>, linuxppc-dev@...ts.ozlabs.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [RESEND] macintosh: Fix spelling mistake "toogle" to "toggle"

Hi,

Le 03/12/2024 à 09:42, Zhu Jun a écrit :
> There is a spelling mistake, Please fix it.

This text doesn't belong to a commit message, the patch cannot be 
applied with such a message.

By the way, can you explain why it is so urgent to fix a minor typo like 
this on a so old driver that hasn't got more than half a dozen of 
commits in the last 10 years, none of them been functionnal changes ?

Anybody who reads this comment will understand it despite the typo. To 
be honest most people won't even notice the type while reading.

Before sending such patches, have in mind the cost of handling such a 
change compared to its real benefit.

> 
> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>
> ---
>   drivers/macintosh/adbhid.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/macintosh/adbhid.c b/drivers/macintosh/adbhid.c
> index b2fe7a3dc471..943a7123786a 100644
> --- a/drivers/macintosh/adbhid.c
> +++ b/drivers/macintosh/adbhid.c
> @@ -604,7 +604,7 @@ adbhid_buttons_input(unsigned char *data, int nb, int autopoll)
>   
>   			case 0x7f:
>   			case 0xff:
> -				/* keypad overlay toogle */
> +				/* keypad overlay toggle */
>   				break;
>   
>   			default: