linux-kernel - Re: [PATCH 3/3] module: Convert default symbol namespace to string literal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p6zlyv5lxec4xtefp4h6vukbyvxy4l4tcrdnhorezooruzm7vg@vobe4dltqrsl>
Date: Tue, 3 Dec 2024 11:41:45 +0100
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Peter Zijlstra <peterz@...radead.org>, 
	Matthias Maennich <maennich@...gle.com>, linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] module: Convert default symbol namespace to string
 literal

Hello Masahiro,

On Tue, Dec 03, 2024 at 07:21:07PM +0900, Masahiro Yamada wrote:
> Commit cdd30ebb1b9f ("module: Convert symbol namespace to string
> literal") only converted MODULE_IMPORT_NS() and EXPORT_SYMBOL_NS(),
> leaving DEFAULT_SYMBOL_NAMESPACE as a macro expansion.
> 
> This commit converts DEFAULT_SYMBOL_NAMESPACE in the same way to
> avoid annoyance for the default namespace as well.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

You were quicker than me, I'm still in the build test phase of a very
similar patch.

> diff --git a/Documentation/core-api/symbol-namespaces.rst b/Documentation/core-api/symbol-namespaces.rst
> index 55886b4e6aea..27a9cccc792c 100644
> --- a/Documentation/core-api/symbol-namespaces.rst
> +++ b/Documentation/core-api/symbol-namespaces.rst
> @@ -68,7 +68,7 @@ is to define the default namespace in the ``Makefile`` of the subsystem. E.g. to
>  export all symbols defined in usb-common into the namespace USB_COMMON, add a

I added quotes around USB_COMMON here --------------------------^, too
(and in the translated variants).

>  line like this to drivers/usb/common/Makefile::
>  
> -	ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=USB_COMMON
> +	ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE='"USB_COMMON"'

And I used

	-DDEFAULT_SYMBOL_NAMESPACE=\"USB_COMMON\"

which is probably just subjective.

Independant of the above:

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)