linux-kernel - Re: [PATCH 2/3] irqchip: Fix a potential abuse of seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ttblt3i1.ffs@tglx>
Date: Tue, 03 Dec 2024 12:22:46 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: David Wang <00107082@....com>
Cc: kees@...nel.org, linux-kernel@...r.kernel.org, geert@...ux-m68k.org,
 David Wang <00107082@....com>
Subject: Re: [PATCH 2/3] irqchip: Fix a potential abuse of seq_printf()
 format string

On Wed, Nov 20 2024 at 17:17, David Wang wrote:
> Using device name as format string of seq_printf() is prone to
> "Format string attack", opens possibility for exploitation.
> Seq_puts() is safer and more efficient.

I agree that seq_puts() is more efficient, but this whole handwaving
about format string attacks is far fetched.

These strings originate from device tree or generated device/domain
names. If they contain format strings, then that's either a plain bug in
the kernel or the device tree, but far from a 'format string attack'.

Thanks,

        tglx