[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABTCjFAZn5g_1ZR0+pN5JgpsikhhajsX0hdaDSvuT2Z-0Um71g@mail.gmail.com>
Date: Tue, 3 Dec 2024 14:28:24 +0300
From: Dzmitry Sankouski <dsankouski@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Sebastian Reichel <sre@...nel.org>, Chanwoo Choi <cw00.choi@...sung.com>, Lee Jones <lee@...nel.org>,
Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>, Pavel Machek <pavel@....cz>,
Hans de Goede <hdegoede@...hat.com>, Marek Szyprowski <m.szyprowski@...sung.com>,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>, Purism Kernel Team <kernel@...i.sm>,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-input@...r.kernel.org,
linux-leds@...r.kernel.org
Subject: Re: [PATCH v9 6/9] mfd: Add new driver for MAX77705 PMIC
пн, 2 дек. 2024 г. в 13:23, Krzysztof Kozlowski <krzk@...nel.org>:
>
> On 02/12/2024 10:47, Dzmitry Sankouski wrote:
> > Add the core MFD driver for max77705 PMIC. We define five sub-devices
> > for which the drivers will be added in subsequent patches.
> >
> > Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
> >
(...)
> > + /* Unmask interrupts from all blocks in interrupt source register */
> > + ret = regmap_update_bits(max77705->regmap,
> > + MAX77705_PMIC_REG_INTSRC_MASK,
> > + MAX77705_SRC_IRQ_ALL, (unsigned int)~MAX77705_SRC_IRQ_ALL);
>
>
> The need for cast comes from some compiler warning?
>
BIT macro creates a 64 bit constant value. When inverted,
it overruns 32 bit value, causing compiler to warn on conversion like
`warning: conversion from ‘long unsigned int’ to ‘unsigned int’`.
--
Best regards and thanks for review,
Dzmitry
Powered by blists - more mailing lists