linux-kernel - Re: [PATCH] wifi: ath11k: allow APs combination when dual stations are supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ccd4b98-9557-4a8b-b493-e01b157c71e2@quicinc.com>
Date: Tue, 3 Dec 2024 09:54:43 +0800
From: "Yu Zhang (Yuriy)" <quic_yuzha@...cinc.com>
To: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>, <kvalo@...nel.org>,
        <jjohnson@...nel.org>, <linux-wireless@...r.kernel.org>,
        <ath11k@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
CC: <quic_cjhuang@...cinc.com>, Vladimir Benes <vbenes@...hat.com>
Subject: Re: [PATCH] wifi: ath11k: allow APs combination when dual stations
 are supported



On 12/2/2024 5:18 PM, Jose Ignacio Tornos Martinez wrote:
> Since commit f019f4dff2e4 ("wifi: ath11k: support 2 station interfaces"),
> if dual stations are supported for a device, we can not configure more that
> one AP and/or DFS cannot be enabled.
> 
Try 
https://lore.kernel.org/all/20241127022742.4016870-1-quic_yuzha@quicinc.com/
> Enable this by creating a new parameter (ignore_support_dual_stations) to
> ignore this feature if it is convenient. Default behavior is to support
> dual stations if possible.
> 
> Reported-by: Vladimir Benes <vbenes@...hat.com>
> Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
> ---
>   drivers/net/wireless/ath/ath11k/core.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
> index be67382c00f6..55c7a55d85ff 100644
> --- a/drivers/net/wireless/ath/ath11k/core.c
> +++ b/drivers/net/wireless/ath/ath11k/core.c
> @@ -37,6 +37,12 @@ bool ath11k_ftm_mode;
>   module_param_named(ftm_mode, ath11k_ftm_mode, bool, 0444);
>   MODULE_PARM_DESC(ftm_mode, "Boots up in factory test mode");
>   
> +static bool ath11k_ignore_support_dual_stations;
> +module_param_named(ignore_support_dual_stations,
> +		   ath11k_ignore_support_dual_stations, bool, 0644);
> +MODULE_PARM_DESC(ignore_support_dual_stations,
> +		 "Ignore the support for dual stations to support other combinations");
> +
>   static const struct ath11k_hw_params ath11k_hw_params[] = {
>   	{
>   		.hw_rev = ATH11K_HW_IPQ8074,
> @@ -2162,6 +2168,9 @@ static int ath11k_init_hw_params(struct ath11k_base *ab)
>   	}
>   
>   	ab->hw_params = *hw_params;
> +	if (ab->hw_params.support_dual_stations &&
> +	    ath11k_ignore_support_dual_stations)
> +		ab->hw_params.support_dual_stations  = false;
>   
>   	ath11k_info(ab, "%s\n", ab->hw_params.name);
>