linux-kernel - drivers/power/supply/cros_usbpd-charger.c:15:49: warning: '%d' directive writing between 1 and 11 bytes into a region of size 5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202412031910.gddwrzU5-lkp@intel.com>
Date: Tue, 3 Dec 2024 19:57:20 +0800
From: kernel test robot <lkp@...el.com>
To: Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Lee Jones <lee@...nel.org>, Gwendal Grignou <gwendal@...omium.org>
Subject: drivers/power/supply/cros_usbpd-charger.c:15:49: warning: '%d'
 directive writing between 1 and 11 bytes into a region of size 5

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   cdd30ebb1b9f36159d66f088b61aee264e649d7a
commit: 47f11e0b40e97f373da4efbacee0a9526c816ed5 mfd / platform: cros_ec: Move cros-ec core driver out from MFD
date:   5 years ago
config: arm64-randconfig-004-20240106 (https://download.01.org/0day-ci/archive/20241203/202412031910.gddwrzU5-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412031910.gddwrzU5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412031910.gddwrzU5-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/power/supply/cros_usbpd-charger.c: In function 'cros_usbpd_charger_probe':
>> drivers/power/supply/cros_usbpd-charger.c:15:49: warning: '%d' directive writing between 1 and 11 bytes into a region of size 5 [-Wformat-overflow=]
      15 | #define CHARGER_USBPD_DIR_NAME                  "CROS_USBPD_CHARGER%d"
         |                                                 ^~~~~~~~~~~~~~~~~~~~~~
   drivers/power/supply/cros_usbpd-charger.c:656:45: note: in expansion of macro 'CHARGER_USBPD_DIR_NAME'
     656 |                         sprintf(port->name, CHARGER_USBPD_DIR_NAME, i);
         |                                             ^~~~~~~~~~~~~~~~~~~~~~
   drivers/power/supply/cros_usbpd-charger.c:15:68: note: format string is defined here
      15 | #define CHARGER_USBPD_DIR_NAME                  "CROS_USBPD_CHARGER%d"
         |                                                                    ^~
   drivers/power/supply/cros_usbpd-charger.c:15:49: note: directive argument in the range [-2147483641, 2147483646]
      15 | #define CHARGER_USBPD_DIR_NAME                  "CROS_USBPD_CHARGER%d"
         |                                                 ^~~~~~~~~~~~~~~~~~~~~~
   drivers/power/supply/cros_usbpd-charger.c:656:45: note: in expansion of macro 'CHARGER_USBPD_DIR_NAME'
     656 |                         sprintf(port->name, CHARGER_USBPD_DIR_NAME, i);
         |                                             ^~~~~~~~~~~~~~~~~~~~~~
   drivers/power/supply/cros_usbpd-charger.c:656:25: note: 'sprintf' output between 20 and 30 bytes into a destination of size 23
     656 |                         sprintf(port->name, CHARGER_USBPD_DIR_NAME, i);
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +15 drivers/power/supply/cros_usbpd-charger.c

f68b883e8fad23 Sameer Nanda  2018-05-02  14  
3af15cfacd1eef Fabien Parent 2018-08-10 @15  #define CHARGER_USBPD_DIR_NAME			"CROS_USBPD_CHARGER%d"
3af15cfacd1eef Fabien Parent 2018-08-10  16  #define CHARGER_DEDICATED_DIR_NAME		"CROS_DEDICATED_CHARGER"
3af15cfacd1eef Fabien Parent 2018-08-10  17  #define CHARGER_DIR_NAME_LENGTH		(sizeof(CHARGER_USBPD_DIR_NAME) >= \
3af15cfacd1eef Fabien Parent 2018-08-10  18  					 sizeof(CHARGER_DEDICATED_DIR_NAME) ? \
3af15cfacd1eef Fabien Parent 2018-08-10  19  					 sizeof(CHARGER_USBPD_DIR_NAME) : \
3af15cfacd1eef Fabien Parent 2018-08-10  20  					 sizeof(CHARGER_DEDICATED_DIR_NAME))
f68b883e8fad23 Sameer Nanda  2018-05-02  21  #define CHARGER_CACHE_UPDATE_DELAY		msecs_to_jiffies(500)
f68b883e8fad23 Sameer Nanda  2018-05-02  22  #define CHARGER_MANUFACTURER_MODEL_LENGTH	32
f68b883e8fad23 Sameer Nanda  2018-05-02  23  

:::::: The code at line 15 was first introduced by commit
:::::: 3af15cfacd1eef7f223802d49a88cae23c509183 power: supply: cros: add support for dedicated port

:::::: TO: Fabien Parent <fparent@...libre.com>
:::::: CC: Sebastian Reichel <sre@...nel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki