linux-kernel - Re: [PATCH resend] bcachefs: BCACHEFS_PATH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jdp4jdy7cj266m5xhrbodosfbj2lxoeykhkcugnbare5dbgkfw@xkpknsymnapl>
Date: Tue, 3 Dec 2024 21:23:48 -0500
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Steven Rostedt <rostedt@...dmis.org>, 
	Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, 
	linux-bcachefs@...r.kernel.org, linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend] bcachefs: BCACHEFS_PATH_TRACEPOINTS should depend
 on TRACING

On Tue, Dec 03, 2024 at 05:40:10PM +0100, Geert Uytterhoeven wrote:
> When tracing is disabled, there is no point in asking the user about
> enabling extra btree_path tracepoints in bcachefs.
> 
> Fixes: 32ed4a620c5405be ("bcachefs: Btree path tracepoints")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Thanks, applied

> ---
>  fs/bcachefs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/bcachefs/Kconfig b/fs/bcachefs/Kconfig
> index ab6c95b895b33591..464b927e4fffd1f2 100644
> --- a/fs/bcachefs/Kconfig
> +++ b/fs/bcachefs/Kconfig
> @@ -90,7 +90,7 @@ config BCACHEFS_SIX_OPTIMISTIC_SPIN
>  
>  config BCACHEFS_PATH_TRACEPOINTS
>  	bool "Extra btree_path tracepoints"
> -	depends on BCACHEFS_FS
> +	depends on BCACHEFS_FS && TRACING
>  	help
>  	Enable extra tracepoints for debugging btree_path operations; we don't
>  	normally want these enabled because they happen at very high rates.
> -- 
> 2.34.1
>