linux-kernel - Re: [PATCH v4 4/5] ARM: vt8500: Switch to new sys-off handler API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABjd4YxYjX2bHSBMmPxH-5muQL5TG_ATS8B0+vCdNKJARke6BQ@mail.gmail.com>
Date: Wed, 4 Dec 2024 17:30:00 +0300
From: Alexey Charkov <alchark@...il.com>
To: Andrew Davis <afd@...com>
Cc: Arnd Bergmann <arnd@...db.de>, Andre Przywara <andre.przywara@....com>, 
	Russell King <linux@...linux.org.uk>, Daniel Mack <daniel@...que.org>, 
	Haojian Zhuang <haojian.zhuang@...il.com>, Robert Jarzmik <robert.jarzmik@...e.fr>, 
	Krzysztof Kozlowski <krzk@...nel.org>, Stefano Stabellini <sstabellini@...nel.org>, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v4 4/5] ARM: vt8500: Switch to new sys-off handler API

Hi Andrew,

On Mon, Dec 2, 2024 at 10:41 PM Andrew Davis <afd@...com> wrote:
>
> Kernel now supports chained power-off handlers. Use
> register_platform_power_off() that registers a platform level power-off
> handler. Legacy pm_power_off() will be removed once all drivers and archs
> are converted to the new sys-off API.
>
> Signed-off-by: Andrew Davis <afd@...com>
> ---
>  arch/arm/mach-vt8500/vt8500.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
> index 0ab40087ae1cc..1d294255d7083 100644
> --- a/arch/arm/mach-vt8500/vt8500.c
> +++ b/arch/arm/mach-vt8500/vt8500.c
> @@ -141,7 +141,7 @@ static void __init vt8500_init(void)
>                         pr_err("%s:ioremap(power_off) failed\n", __func__);
>         }
>         if (pmc_base)
> -               pm_power_off = &vt8500_power_off;
> +               register_platform_power_off(vt8500_power_off);

This really calls for a separate tiny driver under drivers/power to
remove the legacy single-register remapping higher up in this
function... Pending that:

Acked-by: Alexey Charkov <alchark@...il.com>

Best regards,
Alexey