linux-kernel - Re: [PATCH 3/4] staging: gpib: Fix erroneous removal of blank before newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024120410-claim-precut-61e3@gregkh>
Date: Wed, 4 Dec 2024 16:29:43 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Dave Penkler <dpenkler@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Marcello Carla' <marcello.carla@....com>
Subject: Re: [PATCH 3/4] staging: gpib: Fix erroneous removal of blank before
 newline

On Wed, Dec 04, 2024 at 03:57:12PM +0100, Dave Penkler wrote:
> Replace original blanks with "."
> 
> Reported-by: Marcello Carla' <marcello.carla@....com>
> Co-developed-by: Marcello Carla' <marcello.carla@....com>
> Fixes: fce79512a96a ("staging: gpib: Add LPVO DIY USB GPIB driver")
> Signed-off-by: Dave Penkler <dpenkler@...il.com>
> ---
>  drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> index 47db17418a74..c30db3615f49 100644
> --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> @@ -97,8 +97,8 @@ module_param(debug, int, 0644);
>  #define USB_GPIB_DEBUG_ON    "\nIBDE\xAA\n"
>  #define USB_GPIB_SET_LISTEN  "\nIBDT0\n"
>  #define USB_GPIB_SET_TALK    "\nIBDT1\n"
> -#define USB_GPIB_SET_LINES   "\nIBDC\n"
> -#define USB_GPIB_SET_DATA    "\nIBDM\n"
> +#define USB_GPIB_SET_LINES   "\nIBDC.\n"
> +#define USB_GPIB_SET_DATA    "\nIBDM.\n"
>  #define USB_GPIB_READ_LINES  "\nIBD?C\n"
>  #define USB_GPIB_READ_DATA   "\nIBD?M\n"
>  #define USB_GPIB_READ_BUS    "\nIBD??\n"
> @@ -587,7 +587,7 @@ static int usb_gpib_command(gpib_board_t *board,
>  			    size_t *bytes_written)
>  {
>  	int i, retval;
> -	char command[6] = "IBc\n";
> +        char command[6]="IBc.\n";

Did you run this through scripts/checkpatch.pl before sending it out?
Please always do so.

And what is the "." for?  Why is this needed?  Please explain that in
the changelog text.

thanks,

greg k-h